#9296: Add lattice computations for convex polyhedral cones
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5
Component: geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
Personal taste: I like "orthogonal" more than "perpendicular" and it is a
little shorter.
I would like to have internal names in agreement with public ones, it
makes it easier to read/modify and helps to avoid bugs, e.g. the following
code looks strange:
{{{
def sublattice_basis(self):
...
if "_sublattice_basis" not in self.__dict__:
self._compute_N_and_N_complement()
return tuple( self._lattice(n) for n in self._N.rows() )
}}}
In general I think that the best name for caching the result of function
`f` is `_f`, unless it leads to any conflicts. If you don't want to have
too long names in the code, I think abbreviations are fine, as long as
they still clearly relate to the original name, e.g.
`perpendicular_sublattice_basis` can be cached in something like
`_perp_sublat_b`.
How about also `_compute_N_and_N_complement` ===> `_split_ambient_lattice`
or something like this?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9296#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
