#9351: deps for sagetex with SAGE_CHECK='yes'
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.5
Component: spkg-check | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by drkirkby):
Replying to [comment:3 jhpalmieri]:
> Well, I don't know if spkg-check in sagetex uses anything from gap:
various calls in Sage end up calling gap in the background. We could add
sage as a dependency, but unless ddrake says otherwise, I'd like to keep
gap there as well.
I've got no doubt this will work what you are proposing. But given you say
the problem is sagetex calls Sage for testing, I can't understand the
logic of listing gap as a dependency. Why gap?
There is no reference to gap anywhere in the Sagetex source files
{{{
drkir...@hawk:~/SAGE-4.5.alpha1/spkg/standard/sagetex-2.2.5$ ggrep -Ri gap
*
drkir...@hawk:~/SAGE-4.5.alpha1/spkg/standard/sagetex-2.2.5$
}}}
Without an explanation in the 'deps' file, one could easily envisage
someone coming along one day and saying "Sagetex is a typesetting program,
and does not need gap, so lets remove gap as a dependency". That would
break, as the real dependency is Sage, but that fact is obscured. I would
have thought it much safer to explicitly list Sage as a dependency, and
adding a comment like I put above would ensure nobody updating deps would
be under any illusion why Sage is a dependency.
BTW, in SPKG.txt, it says:
{{{
== Dependencies ==
To install, nothing more than a standard Sage install. The
{{{spkg-check}}} script will exit without actually testing anything if
it cannot find "latex" in your path, or if it cannot find tkz-berge.sty,
a TikZ add-on required for typesetting some graphs.
}}}
again, no mention of gap. So I can't see the logic of explicitly listing
gap - it just appears to add confusion, though I would agree that
technically it does achieve the requirement, but via an obscure way.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9351#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
