#9245: Add library of toric varieties
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
I have added extra checks to constructors with parameters and made `P(n)`
to return a Fano variety, as it was described in the documentation, but
the code was for a plain toric variety.
I have also put (-1,-1,-1) as the last ray of `P(3)`. I have no idea what
I was thinking when I asked to have it first. Maybe I was thinking about
`z1, z2, z3` coordinates for `A(3)` and `z0, z1, z2, z3` for `P(3)`, but I
think it is more consistent to let `A(3)` have default coordinates `z0,
z1, z2` and then projectivization adds `z3` in the end. On the level of
fans it definitely makes more sense to put the extra element in the back.
All tests pass for me on 4.5.alpha1, positive review once you approve
(hopefully ;-)) my patch!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9245#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
