#9245: Add library of toric varieties
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
Looks great!
Just a couple more little picks:
* `Cube_deformation(k)` does NOT "Construct a sequence of toric varieties
with torsion in the Chow group" since for every given `k` it will return
only a particular element of the sequence. In the OUTPUT block of this
function, can we turn "toric variety" into a hyperlink?
* I don't quite like that other outputs will look in the documentation
like "An instance of toric variety." I am totally fine without the dash in
the beginning, but I'd prefer either plain-language "Toric variety." or a
longer but more code-accurate "An instance of `ToricVariety_field`." given
by one of these:
{{{
OUTPUT:
:class:`Toric variety
<sage.schemes.generic.toric_variety.ToricVariety_field>`.
OUTPUT:
An instance of
:class:`~sage.schemes.generic.toric_variety.ToricVariety_field`.
}}}
The second point is optional, if "An instance of toric variety." is
exactly what you want, it is OK with me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9245#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
