#8316: Remove the Jinja (not Jinja2) package
----------------------------+-----------------------------------------------
   Reporter:  mpatel        |       Owner:  tbd            
       Type:  enhancement   |      Status:  positive_review
   Priority:  minor         |   Milestone:  sage-4.5       
  Component:  packages      |    Keywords:                 
     Author:  Mitesh Patel  |    Upstream:  N/A            
   Reviewer:  Carl Witty    |      Merged:                 
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by cwitty):

  * status:  needs_review => positive_review
  * reviewer:  => Carl Witty


Comment:

 Thanks for fixing up gen_interpreters.py, your changes look fine (and the
 template output from the patched gen_interpreters.py using jinja2 is byte-
 for-byte identical to the previous output using jinja).

 I tested by starting from sage-4.5.rc1.tar, removing the jinja spkg, and
 applying install.diff and 4.5.rc1-deps.diff (the original deps.diff would
 no longer apply, so I rebased it).  I then typed "make", waited for the
 build to fail, applied trac_8316-remove_jinja.2.patch, and restarted the
 build.  The build was successfull, and all (long) tests passed.

 Positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8316#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to