#9528: #8306 completely breaks "sage -upgrade"
-----------------------+----------------------------------------------------
Reporter: was | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.5.1
Component: build | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------+----------------------------------------------------
Comment(by leif):
Replying to [comment:9 was]:
> Please review. Since spkg/install is pulled in by SAGE_ROOT/local/bin
/spkg-update, this should fix the problem.
I just noticed I had written {{{spkg-install}}} instead of
{{{spkg/install}}}... :/
Of course I prefer generating a version-specific {{{pipestatus}}}, but if
it is a temporary solution, I'm ok with omitting it.
I'd though at least fix {{{pipestatus}}}'s parameter checking as I did in
my second version:
{{{
#!sh
...
cat > pipestatus <<EOF
#!/usr/bin/env bash
if [ \$# -ne 2 -o -z "\$1" -o -z "\$2" ]; then
echo "Run two commands in a pipeline 'CMD1 | CMD2' and exit"
echo "with the exit status of CMD1, *not* that of CMD2."
echo "\$0 cmd1 cmd2"
exit
fi
...
}}}
Dropping the parentheses around {{{(set -o pipefail; eval "\$1 | \$2")}}}
is optional, but you should remove {{{-n}}} from the {{{echo}}} in your
{{{install}}}.
We cannot yet test upgrading from e.g. 4.4.4 though, can we?
(I've tried your {{{install}}} there, it's ok when {{{deps}}} etc. get
updated, too.)
In any case, add a
{{{
#!sh
chmod +x pipestatus
}}}
after the {{{cat}}}...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9528#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
