#9533: Update GSL to the latest upstream release (1.14) & permit parallel
building.
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.1
Component: packages | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by drkirkby):
Replying to [comment:13 leif]:
> A few (more general) questions:
> * Should we make sure that {{{$SAGE_LOCAL}}} is set? (in both {{{spkg-
install}}} and {{{spkg-check}}})
I think that would be wise. I will address that.
> * Should optimization be disabled ({{{-O0}}}) if {{{SAGE_DEBUG}}} is
{{{yes}}} as some other packages do?
To be practical, SAGE_DEBUG is not really going to be very useful, as too
few packages use it. But I can make that change. Even if every .spkg in
Sage used SAGE_DEBUG that way, many upstream packages add -O2 anyway.
> * Anything to add if {{{SAGE_FAT_BINARY}}} is {{{yes}}}?
I do not believe so. This does not link with anything other than ATLAS.
> * I think {{{CFLAGS}}} et al. should be set in {{{spkg-check}}} as
well, as {{{make check}}} usually involves compilation, too.
In general you are right, but in this case it is not necessary. I know
that, as I was using SAGE64 set to yes to add the -m64 option. That's a
pretty critical option on 64-bit builds, but it was not necessary to add
it. I assume that's in the Makefile which has already been created.
But I accept it would be safer, just in case GSL change the build process
in some way. I am aware of cases where this has been an issue in {{{spkg-
check}}}. I'll modify that.
> * Also modifying {{{LDFLAGS}}}, e.g. if {{{SAGE64=yes}}}, even if
currently not directly used by upstream, should be safe.
Yes, again, it may be safer to do this.
> P.S.: My intention regarding the {{{else ... exit 0}}} part was rather
avoiding other people adding "dead code" below it. Looking at the (fairly
small) file in whole this seems less a danger... :)
No problem. I did wonder if its best to exit a script with {{{exit 0}}}
rather than just let it exit. I know you can get away without specifying
an exit code, but I'm not sure if it's good practice or not.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9533#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
