#9533: Update GSL to the latest upstream release (1.14) & permit parallel
building.
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.1
Component: packages | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by leif):
At first glance (I only looked at the patches) ok, except
* ''Append'' to {{{CFLAGS}}} et al. rather than set/overwrite them
* Typo: 1x s/builing/building/ (2nd patch SPKG.txt)
* Perhaps add to SPKG.txt that {{{spkg-check}}} also now uses {{{$MAKE}}}
* Move the "successful check" message out of the else part, right to the
bottom ;-)
I don't know why you want to create a single patch, but you can simply
take an old vanilla GSL spkg and apply your patches in order with {{{hg
import --no-commit ...}}} (or use {{{patch}}}), and after that, just do a
commit.
I'll take a closer look at the package tomorrow, I think.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9533#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
