#8667: New version of modular group cohomology spkg
---------------------------------+------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.5.2
Component: optional packages | Keywords: modular cohomology finite group
Author: Simon King | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by was):
* status: needs_review => positive_review
Comment:
(1) Add an .hgignore file to the hg repo:
{{{
$ hg status
? src/bin/checksum
? src/bin/chop
? src/bin/chop.o
...
}}}
(2) In spkg-install, change
{{{
# building parallely is bad. Therefore, although it is probably bad style:
MAKE=make; export MAKE;
}}}
to
{{{
unset MAKE
}}}
The doctest coverage is excellent:
{{{
wst...@sage:~/build/referee/sage-4.5/spkg/build/p_group_cohomology-2.0/src/pGroupCohomology$
sage -coverage .
__init__.py: 100% (6 of 6)
barcode.py: 100% (15 of 15)
cochain.pyx: 95% (108 of 113)
cohomology.pyx: 100% (92 of 92)
dickson.pyx: 100% (4 of 4)
modular_cohomology.pyx: 100% (30 of 30)
mtx.pyx: 100% (40 of 40)
resolution.pyx: 95% (59 of 62)
Overall weighted coverage score: 97.6%
Total number of functions: 362
We need 5 more function to get to 99% coverage.
}}}
This package is amazing! It's also an amazing example of how to make an
optional Sage package that involves lots of serious Cython code, but isn't
part of the Sage library.
And, all tests pass (on sage.math).
So, positive review. However, fix (1),(2) above at some point (this is a
minor nitpick).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8667#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
