#9074: Expand latex support for combinatorial graphs via tkz-graph
-----------------------------+----------------------------------------------
Reporter: rbeezer | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.5.2
Component: graph theory | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: John Palmieri | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by rbeezer):
* status: needs_work => needs_review
* reviewer: => John Palmieri
Comment:
Hi John,
Nice catch with the random order doctesting - see below.
(1) \LaTeX -> LaTeX and the two suggested edits have been made.
(2) Big doctest failed with a random order because I was
not using a sorted version of the vertex list, so a change has
been made to the code to always use a single sorted list.
Only the list really isn't sorted since graphs allow
nearly arbitrary objects to be vertices. So I removed
the relabeling of vertex 1 as a symbolic expression. I'll
pursue this on sage-devel. Doctest should now work
consistently, even under random ordering.
(3) Discovered a typo in the error checking for
"edge_label_placements" since a doctest was raising
an error (when it shouldn't have). That code has been fixed.
(4) I made the suggested change with the cached function.
Then other doctests began to fail. And that function
itself began to fail doctests with a random order, and
still does despite restoring the original state. So
I'm afraid I don't get it on this one, and I'm not
the original author. Can we move the two problems:
(a) not in the docs, and (b) failing random tests;
to another ticket (I'll do it)?
I've run tests in the graph directory, built html
and jsmath documentation. I've attached a "v4-plus"
patch so you can see the changes, it needs to go on
top of the v4 patch.
Thanks for all your careful work on this!
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9074#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
