#6456: Upgrade cvxopt in sage from 0.9 to 1.1.2
--------------------------------+-------------------------------------------
Reporter: was | Owner: mabshoff
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.5.2
Component: packages | Keywords:
Author: schilly, dimpase | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by dimpase):
* status: needs_work => needs_review
Comment:
Replying to [comment:28 mhansen]:
> I don't think this is ready to go in. Some issues:
>
> 1. I don't think there should be a patches-old directory. If people
need them for historical reasons, then they should get them from the hg
repo since that's what it is there for.
>
> 2. Files are modified in place in the src/ directory. That should be as
close to clean as vanilla upstream as possible. The modified files should
be copied over from patches/
>
> 3. In the patches directory, the patches should be unified diffs (diff
-Naur).
>
> 4. In spkg-install, you should just remove the old, unnecessary code
instead of just commenting it out. Also, I don't think the SAGE_LOCAL
check is necessary.
the update, that takes your comments into account, is here
http://boxen.math.washington.edu/home/dima/packages/cvxopt-1.1.2.spkg
Please have a look, hopefully it is OK now.
Dima
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6456#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
