#9444: Fix "rm: Cannot remove any directory in the path of the current working
directory" on t2
------------------------------+---------------------------------------------
Reporter: mpatel | Owner: drkirkby
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-5.0
Component: solaris | Keywords:
Author: Mitesh Patel | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by leif):
* status: needs_review => positive_review
* reviewer: => Leif Leonhardy
Comment:
I'm ok with the patch, though we could replicate
{{{
#!sh
# Make triply sure that we are in the build directory before doing
# a scary "rm -rf".
cd "$SAGE_PACKAGES/build"
if [ $? -ne 0 ]; then
echo "Unable to find build directory."
else
rm -rf "$PKG_BASE-"*
fi
}}}
which is what is done some lines above.
There are many other things to fix or improve in {{{sage-spkg}}}, but I'll
leave those for further tickets (something like work in progress) since
hopefully this one gets merged soon.
If anyone feels Mitesh's solution is not sufficient, feel free to revert
it to "needs review" or "needs work".
-Leif
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9444#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
