#9621: Fix GAP interface problem in sylow_subgroup method
--------------------------------------------------------------+-------------
Reporter: SimonKing | Owner:
joyner
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.5.2
Component: group_theory | Keywords:
GAP string representation
Author: Simon King, Johan Sebastian Rosenkilde Nielsen | Upstream:
N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------------------------------------+-------------
Comment(by jsrn):
Ah, embarrassing; I had seen that mistake, but must have forgotten to
remake the patch or something :-)
Thanks for adding me as author. I guess we'll have to wait for a nice
person to come along and review the (final?) patch.
Regards,
Johan
Replying to [comment:3 SimonKing]:
> Hi Johan!
>
> Replying to [comment:2 jsrn]:
> > It seems that some parsing functionality has already been built into
the gap interface, so all the last lines of sylow_subgroups can be greatly
simplified.
>
> You have a misprint in your patch. You wrote self_element_class(), but
it should be self._element_class().
>
> However, your suggestion makes indeed sense. So, I created a patch that
corrects that misprint and combines both of our patches into one.
>
> Now the big question is: I think we are both Authors now (and I inserted
your name in the corresponding field of this ticket). So, who will
review??
>
> Cheers,
> Simon
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9621#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
