#9443: infinite polynomial ring is_integral_domain and is_field omit optional
argument 'proof'
---------------------------------------------------+------------------------
Reporter: niles | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5.2
Component: algebra | Keywords: infinite
polynomial ring
Author: niles | Upstream: N/A
Reviewer: | Merged:
Work_issues: Add ticket number to commit message |
---------------------------------------------------+------------------------
Changes (by SimonKing):
* priority: trivial => major
* status: needs_review => needs_work
* work_issues: => Add ticket number to commit message
Comment:
Thank you for working on Infinite Polynomial Rings! Why didn't you add me
(as original author) to Cc? I think I am a natural candidate for being
reviewer...
First of all, the patches apply cleanly, and {{{sage -b}}} does not
complain.
Second, I think the patches provide a clean solution. I am sorry that I
didn't use {{{*args}}} and {{{**kwds}}} in the first place.
Third, it is a formal requirement that the commit message of each patch
must point to the relevant ticket. So, could you please add "#9443: " or
so to the commit messages? Moreover, the attachments name a wrong ticket
number (9943 rather than 9443).
Fourth, I am now running {{{make ptestlong}}} and report back whether it
has worked.
Fifth, since you fix a bug, I believe the priority is certainly not
"trivial". I am promoting it to "major".
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9443#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
