#9337: Add toric divisors
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by vbraun):
Nothing can go wrong (knock on wood) in
Divisor_generic([(self.base_ring()(1), x)]) and it cannot be reduced, so I
manually set `check=False`, `reduce=False`. The same was already in
`FormalSums_generic.__call__()` before I converted it to
`_element_constructor_()`:
{{{
return FormalSum([(self.base_ring()(1), x)], check=False, reduce=False,
parent=self)
}}}
But if you don't like this optimization I can take it out.
About `UniqueFactory` vs. `UniqueRepresentation`, I guess you answered
your own question: If you want default arguments then you need an explicit
factory. Otherwise you can just use `UniqueRepresentation`, which is its
own factory.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
