#9337: Add toric divisors
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: new
Priority: major | Milestone:
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
Looks impressive, although I will wait till prerequisites are finished
before carefully going over the code. Volker, can you split this patch
into two so that one "fixes the old stuff" and the other deals with our
new toric modules?
One thing I have noticed so far that doctests in
`schemes/plane_curves/projective_curve` fail because of renaming `coef` to
`coefficient`. Why did you change the name? I.e. is it just your personal
preference or it is more consistent with other things? My personal
preference is definitely `coefficient`, but since it can break existing
code we should either put a deprecation warning in `coef`, or make it an
alias to the new coefficient.
We also should straighten out our patch queue and ticket dependencies, now
that a big chunk of it is gone. How about the following one?
* #9470
* #9326
* #9502
* #9504
* #9296
* #9337
* #9380
Doctesting the patch on this ticket, it seems that it uses code from
#9380, and that ticket definitely should not go before this one. However,
I don't mind if you completely or partially flatten it into this one
(almost all code there is yours anyway).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
