#9567: Networkx-1.1 spkg
----------------------------+-----------------------------------------------
   Reporter:  bedwards      |       Owner:  jason, ncohen, rlm        
       Type:  enhancement   |      Status:  needs_review              
   Priority:  minor         |   Milestone:  sage-4.5.2                
  Component:  graph theory  |    Keywords:  networkx spkg graph theory
     Author:  Ben Edwards   |    Upstream:  N/A                       
   Reviewer:                |      Merged:                            
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by ncohen):

 Hello Ben !!!

 I added a small patch containing the method cycle_basis (with a long
 doctest), that just calls NetworkX's. I haven't been able to properly
 write a cycle_space method (see http://groups.google.com/group/sage-
 
support/browse_thread/thread/f99b59eaabf679a5/8bf34d54c183ab6b?lnk=gst&q=labelled#8bf34d54c183ab6b),
 so I tried to give a satisfying example in this docstring.

 I give a positive review to your own patch for your patch/spkg, short of
 these two details :

  * I fixed some occurences of "dictionary" in my own patch
  * Your NetworkX SPKG has "uncommitted changes". Could you do a "hg
 commit", then upload the new version ? ( You can notice this when using
 the "sage -pkg" command to build spkg).

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9567#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to