#9567: Networkx-1.1 spkg
----------------------------+-----------------------------------------------
Reporter: bedwards | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.5.2
Component: graph theory | Keywords: networkx spkg graph theory
Author: Ben Edwards | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by mpatel):
* status: positive_review => needs_work
Comment:
Should I apply exactly
* http://spkg-upload.googlecode.com/files/networkx-1.2.spkg
* [attachment:14602.patch]
* [attachment:trac_9567-cycle_basis.patch]
to merge this ticket?
I'm changing the status to 'needs_work' for this: The first patch is
missing the ticket number in the first line of its commit string. The
first line itself should also be short (< 80 characters) but stand on its
own, in order to keep `hg log` listings succinct and informative. Of
course, there's no problem with extra lines that describe the changes in
detail.
The second patch's commit string should perhaps be a bit more descriptive.
Also, please update the Author(s) and Reviewer(s) fields.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9567#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.