#8059: update Singular SPKG to newest upstream release
----------------------------------------------------------------------+-----
Reporter: malb |
Owner:
Type: enhancement |
Status: positive_review
Priority: major |
Milestone: sage-4.5.2
Component: packages |
Keywords:
Author: Martin Albrecht |
Upstream: Reported upstream. Little or no feedback.
Reviewer: David Kirkby, Simon King, William Stein, John Palmieri |
Merged:
Work_issues: rebase patch |
----------------------------------------------------------------------+-----
Changes (by drkirkby):
* status: needs_work => positive_review
Comment:
Replying to [comment:104 SimonKing]:
> Replying to [comment:103 jhpalmieri]:
> > With #1396 backed out, this applies, so it doesn't need to be rebased.
(One hunk applies "with fuzz".)
>
> Good!
>
> > The commit message doesn't include the trac number, but that's the
only problem.
>
> Well, I recently got a "needs work" for the same reason...
>
> > So should it get a positive review now?
>
> I wouldn't oppose. Any veto?
Me neither. I'm going to set it to positive review.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8059#comment:105>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.