#9504: Add support for toric sublattices
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.3
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: quotient lattices |
----------------------------------+-----------------------------------------
Changes (by vbraun):
* reviewer: => Volker Braun
* milestone: sage-4.5.2 => sage-4.5.3
Old description:
> Following discussion of #9296, I am rewriting toric lattices to allow
> construction of sublattices.
>
> Apply after #9245 and #9502.
New description:
Following discussion of #9296, I am rewriting toric lattices to allow
construction of sublattices.
See the tracker bug #9604 for details on dependencies.
--
Comment:
In the patch below I:
* changed the `_repr_()` output as per my previous comment
* allow coercion from quotient lattice into a new `ToricLattice`, see
the changed docstring of `ToricLattice.__call__`.
* some pickling fixes
* added a method `ToricLattice_quotient._make_generator_positive_on()`
to change the sign of a generator as required for the lattice computations
later.
With these changes, I'm ready to give it a positive review. Let me know if
you agree :-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9504#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
