#9504: Add support for toric sublattices
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-4.5.3
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: quotient lattices |
----------------------------------+-----------------------------------------
Changes (by novoselt):
* status: needs_review => needs_info
Comment:
I agree in general, but have some comments:
* Thanks for catching my copy-pasted missing ":"!
* `_repr_` modification is great, it does make the description more
clear.
* What is called "coercion" in the documentation and comments is
"construction/conversion" since it does not happen implicitly (and I don't
think that it should!).
* Pickle improvement are also great, but the function `unpickle_v1` is
missing documentation and tests and shows in `sage -coverage`.
Finally, I don't quite like new treatment of `gens` and I am a bit
confused with its implementation:
* Is it possible for your purposes to pass "the point generator should be
positive on" as an optional argument to constructor, i.e. something like
{{{
sage: Q = N.quotient(sublattice, positive_point=point)
}}}
My point is that I expect generators to be fixed, but the proposed
version makes it is possible to change them after creation. If it is
really necessary to set it up later, let's leave it as is.
* Why the requirement is to get positive pairing with some element of the
covering lattice? Shouldn't it be an element from the lattice dual to
`self.cover()`? Then the important sign will be `self.lift() * point`
rather then the expression involving multiple conversions to circumvent
the "defense system" against pairing of elements of the same lattice.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9504#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
