#9603: Force iconv to build + install on HP-UX. Currently it is only installed
on
Solaris and Cygwin.
--------------------------------------------+-------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-5.0
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Peter Jeremy, Leif Leonhardy | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by leif):
Replying to [comment:23 drkirkby]:
> Replying to [comment:21 leif]:
> > Unfortunately, I'd make ''a lot'' of changes (besides those I already
mentioned), in different "categories", but most of them more or less
important or of cosmetic nature.
>
> But those lots of changes should be on another ticket. They have nothing
to do with fixing the HP-UX issue!
If you don't emphasize/focus on HP-UX (i.e. e.g. add ''"improve iconv
package"''), perhaps more people will take a look at this ticket. :)
> As you know, I am quite keen to improve the quality of Sage, so I will
make them. But be aware I've tried to get people to make more important
changes before, and William has overruled, saying that the patch fixes the
problem it aims to fix, and that other changes should be on another
ticket.
Perhaps sometimes [http://en.wikipedia.org/wiki/Procrastination this]. But
it really depends on whether the changes are to the Sage library or spkgs,
and - more important - on the type of the changes. If major bugs have to
be fixed, doing so shouldn't be delayed by cosmetic improvements. Other
code changes carry the risk of introducing new issues, so it might be
appropriate to separate them. Others are better done at the same time,
especially to avoid conflicting patches/tickets, and I think we don't want
to create lots of new spkgs in sequence fixing "minor" things step by
step.
''Either'' change 10 ''or'' 10000 bytes..., i.e. fix a single issue ''and
open a follow-up ticket'' (with instructions) for ''all'' the rest, or do
the whole job. My opinion. (Almost nobody will open a ticket to fix a
single typo, and people seem unlikely to review "cosmetic" tickets.
Similar to the apparently ever-lasting documentation problem.)
> I'll produce a new package in a day or so.
Or just upload one (or more) patch(es) prior to creating a new spkg.
> > * The following is perhaps (partly) obsolete, but currently
completely misleading:
> > ''"spkg-install removes ALL files installed by iconv - man pages,
docs, etc etc. If iconv gets updated, check these still remove all traces
of iconv.''
>
> The point of that is that if you run {{{make install}}}, then run the
package for a second time, it will clean out all the files made on a
previous build. You can't do {{{make distclean}}} at that point as there's
no makefile. But I'll remove that.
I'd simply clarify that. (And emphasize somehow this is unrelated to the
next sentence/paragraph:)
> > ''The sizes of the docs and man pages is small, so they are not
work removing from the package, as they potentially risk breaking the
install."''
> Nothing is removed. It was just a remark. I can remove it if you feel it
causes confusion.
(See above.) Perhaps make this an explicit, ''separate'' suggestion
(''"TODO:"'') to avoid confusion.
> > * Some messages and comments need clean-up (punctuation,
grammar/typos, and IMHO formulation; some messages perhaps also
"layout")...
>
> I'll try, but lets hope there are not too many itterations of this!
:) I fear that, too. Perhaps create a ''separate'' patch for that (or omit
it in the first place), and let Peter or me create a reviewer patch on top
of the other changes.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9603#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
