#9603: Force iconv to build + install on HP-UX. Currently it is only installed
on
Solaris and Cygwin.
--------------------------------------------+-------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Peter Jeremy, Leif Leonhardy | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by leif):
Unfortunately, I'd make ''a lot'' of changes (besides those I already
mentioned), in different "categories", but most of them more or less
important or of cosmetic nature.
The only actual change ''to the code'' is quoting all instances of
{{{$SAGE_LOCAL}}}, for (far) future support of spaces in {{{$SAGE_ROOT}}}.
(In addition, one ''could'' test if spaces in it would break
{{{configure}}} or {{{make}}} etc.)
In random order:
* Remove trailing whitespace (and a superfluous semicolon in {{{spkg-
install}}} and {{{spkg-check}}}).
(I really hate such changes, since they make [cumulative] patches
unreadable.)
* {{{s/== iconv ==/= iconv =/}}} since it is the top-level heading.
* Add blank lines below section headings. (I think this is common
practice, and makes the plain text more readable.)
* Move ''"For more details ..."'' to (new) ''"Upstream Contact"''
section.
* The following is perhaps (partly) obsolete, but currently completely
misleading:
''"spkg-install removes ALL files installed by iconv - man pages,
docs, etc etc. If iconv gets updated, check these still remove all traces
of iconv.''
''The sizes of the docs and man pages is small, so they are not work
removing from the package, as they potentially risk breaking the
install."''
(In fact '''nothing''' is removed '''after''' {{{make install}}}. I
don't think something has been removed from the upstream source tree; at
least in {{{spkg-install}}} nothing gets removed ("patched") from that,
and {{{configure}}} doesn't get any {{{--without-...}}} options or alike.
In short, when updating the package, one should make sure all traces of
''previous installations'' of iconv still get removed ''prior to
[re]installation''. Otherwise some code has to be added to remove
"useless" parts of iconv ''from the Sage installation'' '''after'''
{{{make install}}}.)
* One could add the usual ''"Building a 64-bit version of ..."'' message.
* Some messages and comments need clean-up (punctuation, grammar/typos,
and IMHO formulation; some messages perhaps also "layout")...
I've looked at the package yesterday, but I don't think I've forgotten
something... ;-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9603#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
