#9296: Add lattice computations for convex polyhedral cones
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.3
Component: geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by novoselt):
* work_issues: switch to using sublattices (#9504) =>
Comment:
I fixed some typos and broke very long lines in doctests (such things make
the documentation look a bit weird when it is shown in narrow windows).
I also think that optional `point` argument should be removed from
`sublattice_quotient` since in the new framework
`cone.sublattice_quotient(p)` is equivalent to
`cone.sublattice_quotient()(p)` and while the second variant does not look
quite as nice it has the advantage of always using the same constructor
for elements with different forms of input which are documented in a
single place. For example, it is possible to write
{{{
sage: c = Cone([(1,0)])
sage: c.sublattice_quotient()(0)
N[0, 0]
sage: c.sublattice_quotient()(0,1)
N[0, 1]
sage: c.sublattice_quotient()([0,1])
N[0, 1]
}}}
but
{{{
sage: c.sublattice_quotient(0,1)
...
TypeError: sublattice_quotient() takes at most 2 arguments (3 given)
}}}
It will also make all cone-lattice methods more uniform in their behaviour
(i.e. they don't take any arguments). In fact, by the end of writing this
I got so convinced that this is the way to go that my patch will do the
proposed change ;-) It may affect the subsequent patches, if this
functionality was used already, but corrections will be trivial.
If you are fine with the changes, this ticket finally gets positive
review!!!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9296#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
