#9735: Numerical noise on sage/stats/hmm/chmm.pyx on both Solaris x86 and
OpenSolaris x86
-----------------------------+----------------------------------------------
   Reporter:  drkirkby       |       Owner:  mvngu          
       Type:  defect         |      Status:  positive_review
   Priority:  major          |   Milestone:  sage-4.5.3     
  Component:  doctest        |    Keywords:                 
     Author:  John Palmieri  |    Upstream:  N/A            
   Reviewer:  David Kirkby   |      Merged:                 
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by drkirkby):

  * status:  needs_review => positive_review
  * reviewer:  => David Kirkby


Comment:

 Thanks for writing the doctest John.

 Here's a couple of things worth noting

  == Comments by others about this issue ==


 {{{
 FWIW, here is the exact expected result in (obtained from my own
 implementation, no proof but seems to be the same):
 ([0, 0, 1, 1, 0], -5/2*log(pi) - 15/2*log(2) - 1)

 and in high precision:
 ([0, 0, 1, 1, 0],
 -9.0604285688230902559878092893189710396844880399901933346892)

        Yann
 }}}

 and another from William Stein that:

 {{{
 I'm the upstream author of 100% of this code, and know precisely what
 it does, which is a sequence of floating point ops and calls to the
 math library, which *of course* can be machine dependent.

 Put in dots.

  -- William
 }}}

  == Test results on my Sun Ultra 27 ==

 Prior to adding your patch I got a failure recorded in ptestlong.log, as
 noted in the ticket's description. After adding your patch, this passes.

 {{{
 drkir...@hawk:~/32/sage-4.5.3.alpha0$ ./sage -t  -long
 devel/sage/sage/stats/hmm/chmm.pyx
 sage -t -long "devel/sage/sage/stats/hmm/chmm.pyx"
          [11.1 s]

 ----------------------------------------------------------------------
 All tests passed!
 Total time for all tests: 11.2 seconds
 }}}

 So positive review.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9735#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to