#9221: update matplotlib to 1.0.0 and clean out the patches
---------------------------+------------------------------------------------
   Reporter:  jason        |       Owner:  jason, was                           
         
       Type:  enhancement  |      Status:  needs_work                           
         
   Priority:  major        |   Milestone:  sage-4.5.3                           
         
  Component:  graphics     |    Keywords:                                       
         
     Author:  Jason Grout  |    Upstream:  Reported upstream. Developers 
acknowledge bug.
   Reviewer:               |      Merged:                                       
         
Work_issues:               |  
---------------------------+------------------------------------------------

Comment(by drkirkby):

 It's not so easy to test the upstream source code directly, as there are
 dependencies which are not provided on Solaris. On 't2.math' I get:

 {{{
 kir...@t2:32 ~/matplotlib-1.0.0$ python setup.py build
 basedirlist is: ['/usr/local']
 ============================================================================
 BUILDING MATPLOTLIB
             matplotlib: 1.0.0
                 python: 2.4.4 (#1, Jan 10 2007, 01:25:01) [C]
               platform: sunos5

 REQUIRED DEPENDENCIES
                  numpy: no
                         * You must install numpy 1.1 or later to build
                         * matplotlib.
 }}}

 But Numpy has a whole list of dependencies of its own, so I don't want to
 spend a long time setting that lot up.

 But I just retried your .spkg on 't2' using a working copy of the latest
 {{{sage-4.5.3.alpha0}}} and find exactly the same problem.

 I also tried on my !OpenSolaris machine inside a slightly modified version
 of {{{sage-4.5.3.alpha0}}}. Again, I get the same problem as before.

 To me this looks like an upstream bug, and not anything introduced in
 Sage.

 I just checked the source code, and see the code is actually in
 matplotlib-1.0.0.

 {{{
 // Prevent multiple conflicting definitions of swab from stdlib.h and
 unistd.h
 #if defined(__sun) || defined(sun)
 #if defined(_XPG4)
 #undef _XPG4
 #endif
 #if defined(_XPG3)
 #undef _XPG3
 #endif
 #endif
 }}}

 It seems a bit of a hack to me. If {{{_XPG4}}} or {{{_XPG3}}} are defined,
 there were defined for good reason, and I doubt simply undefining them is
 the right way to tackle this. I could imagine this could cause a whole lot
 more problems than it solves.

 According to http://en.wikipedia.org/wiki/X/Open the
 [http://en.wikipedia.org/wiki/Single_UNIX_Specification Single UNIX
 Specification] was based on the XPG4 standard, so I would not be surprised
 that undefining {{{_XPG4}}} will cause problems as the behavior of
 hundreds of header files will be changed.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9221#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to