#9315: sage-4.4.3, 4.4.4: Basic pickling bug in finite fields
--------------------------------+-------------------------------------------
Reporter: was | Owner: AlexGhitza
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.5.3
Component: basic arithmetic | Keywords:
Author: William Stein | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
Comment:
Replying to [comment:10 was]:
> Replying to [comment:8 cremona]:
> > I am reviewing this now. Question: is it not possible to avoid the
code duplication? Could we not have a {{{__reduce()__}}} function in the
base class that could somehow detect whether or not that is appropriate to
use? Perhaps all finite fields should on creation be given a tag to say
whether or not they fall under the factory framework?
> >
> > I guess that you considered this already, and that it is harder than I
am suggesting.
> >
>
> Yes, i tried for several hours to figure out how to do that and failed
completely. Obviously, if somrbody can find a way to do whatvyou propose
that might be good. But the fact is the currrent patch fixes a major bug,
and nobody has suggested a better fix.
>
I guessed you would have tried.
> > On with the testing, anyway!
All tests pass (sage -tp 10 -long).
Unfortunately, this does not fix #9409. But as it is not certain that
pickling of residue fields is the issue there (though I reckon it must be)
I will not delay this one on that account.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9315#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
