#9761: Adjust spkg/standard/deps to build Python before zn_poly
-----------------------+----------------------------------------------------
   Reporter:  mpatel   |       Owner:  GeorgSWeber
       Type:  defect   |      Status:  new        
   Priority:  blocker  |   Milestone:  sage-4.5.3 
  Component:  build    |    Keywords:             
     Author:           |    Upstream:  N/A        
   Reviewer:           |      Merged:             
Work_issues:           |  
-----------------------+----------------------------------------------------
Changes (by leif):

 * cc: pjeremy (added)


Comment:

 {{{src/configure}}} is nice:
 {{{
 #!sh
 #!/bin/sh

 #
 # This script just calls makemakefile.py.
 # See that file for the real configure script.
 #

 if test $# -ne 0
 then
    python makemakefile.py "$@" > makefile
 else
    python makemakefile.py > makefile
 fi
 }}}

 Looking at that Python script:
 {{{
 #!sh
 ~/Sage/spkgs/zn_poly-0.9.p5$ wc -l src/makemakefile.py
 274 src/makemakefile.py
 ~/Sage/spkgs/zn_poly-0.9.p5$ grep -c print src/makemakefile.py
 119
 ~/Sage/spkgs/zn_poly-0.9.p5$ grep -c "^#" src/makemakefile.py
 31
 ~/Sage/spkgs/zn_poly-0.9.p5$ grep -c "^$" src/makemakefile.py
 47
 }}}

 Much of the rest just defines lists of strings (filenames), and afterwards
 prepends some directory/path to each of the list elements. Then some
 strings are concatenated, partly with case distinctions. (Ok, option
 parsing is another job done, but most of it should be in a
 {{{Makefile.in}}}.)

 I wonder if we could simply replace this by (making use of) a pregenerated
 file for the purpose of Sage, using some shell variables. IMHO requiring
 Python here is like requiring autotools to be present.

 Btw, from {{{spkg-install}}} it is pretty clear that this package requires
 Python:
 {{{
 #!sh
 $ grep makemake spkg-install
    cp patches/makemakefile.py src/makemakefile.py
    sed 's/-soname/-h/g' src/makemakefile.py > /tmp/makemakefile.py.$$
    mv /tmp/makemakefile.py.$$ src/makemakefile.py
 }}}

 Just my needless 2 cents...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9761#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to