#9761: Adjust spkg/standard/deps to build Python before zn_poly, and make two
other dependencies explicit
------------------------------+---------------------------------------------
Reporter: mpatel | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-4.5.3
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by leif):
Replying to [comment:21 drkirkby]:
> Replying to [comment:19 leif]:
> > I would have liked a {{{SOME_PYTHON}}} target, but the comment on
zn_poly's rule should be enough for the moment.
>
> I'm not sure a {{{SOME_PYTHON}}} target is a good idea myself. But
anyway, that is '''far''' outside the scope of this ticket. Such a change
needs discussion on sage-devel - not a trac ticket.
For now, I just meant:
{{{
#!diff
--- deps.orig 2010-08-19 01:30:33.000000000 +0200
+++ deps 2010-08-19 03:00:48.000000000 +0200
@@ -129,6 +129,12 @@
$(INST)/$(DIR)
$(INSTALL) "$(SAGE_SPKG) $(SAGE_SCRIPTS) 2>&1" "tee -a
$(SAGE_LOGS)/$(SAGE_SCRIPTS).log"
+# A (perhaps system-wide) Python that's only used for scripting
+# in the build process of a Sage package:
+some_python: $(INST)/$(PYTHON)
+ # We currently only use Sage's Python, even if another
+ # (functional) Python is already present.
+
########################################
# Building normal packages
########################################
@@ -374,7 +380,7 @@
# zn_poly really does depend on Python, despite this is far from obvious.
# The 'configure' script in zn_poly calls Python to make a 'makefile'
-$(INST)/$(ZNPOLY): $(BASE) $(INST)/$(MPIR) $(INST)/$(PYTHON)
+$(INST)/$(ZNPOLY): $(BASE) $(INST)/$(MPIR) some_python
$(INSTALL) "$(SAGE_SPKG) $(ZNPOLY) 2>&1" "tee -a
$(SAGE_LOGS)/$(ZNPOLY).log"
# setuptools forgets to update easy-install.pth during parallel
@@ -468,7 +474,7 @@
$(INSTALL) "$(SAGE_SPKG) $(SAGE) 2>&1" "tee -a
$(SAGE_LOGS)/$(SAGE).log"
# Do not remove PYTHON below -- see trac 9368
-$(INST)/$(FORTRAN): $(BASE) $(INST)/$(PYTHON)
+$(INST)/$(FORTRAN): $(BASE) some_python
$(INSTALL) "$(SAGE_SPKG) $(FORTRAN) 2>&1" "tee -a
$(SAGE_LOGS)/$(FORTRAN).log"
$(INST)/$(F2C): $(BASE) $(INST)/$(FORTRAN)
}}}
This makes the ''reason'' for the dependency more clear - even without
further comments, and the rule for {{{some_python}}} can simply be changed
in the future to actually make use of another Python - without the need
for changing other rules.
And it's formal, not prose.
----
> I'll fix #9762, which you clearly thought was more important than me!
QA says it should definitely be a blocker. ;-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9761#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
