#9766: Cliquer - Update Upstream contact
------------------------+---------------------------------------------------
Reporter: ncohen | Owner: tbd
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5.3
Component: packages | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
That looks a bit better, but I would suggest a few changes.
* Add the trac number (#9766) on the cliquer-1.2.p6 entry.
* State the URL was added to SPKG.txt - at the moment we have no idea
where it was added.
* State you added the {{{Special Update/Build Instructions}}} and
{{{Dependencies}}} to SPKG.txt which were previously missing.
* I think it should be URL, not url, though that's a minor point.
I noticed there was no spkg-check file to run the self-tests, which the
package does have. That needs addressing, but on another ticket, as it's
quite separate. I created a ticket for that (#9767) and will address that
at some point myself, if nobody beats me to it.
As such, it might be wise to put a note of this fact - one suggestion is
below.
{{{
== Special Update/Build Instructions ==
* TODO - Add an spkg-check file - see #9767
}}}
Once that is done, I expect to be able to give it a positive review.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9766#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
