#9650: Adding support for differential forms
-----------------------------------------------------------+----------------
Reporter: jvkersch | Owner:
burcin
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-4.5.3
Component: symbolics | Keywords:
forms, functions, symbolics
Author: Joris Vankerschaver | Upstream: N/A
Reviewer: Niles Johnson | Merged:
Work_issues: __init__.py, documentation warnings, gens() |
-----------------------------------------------------------+----------------
Changes (by niles):
* cc: niles (added)
* reviewer: => Niles Johnson
* status: needs_review => needs_work
* work_issues: => __init__.py, documentation warnings, gens()
Comment:
Hi Joris,
I saw your e-mail to `sage-devel`, so here's my review :) This looks like
a nice patch, and it works nicely enough that I had to resist the
temptation to ask for more functionality (which you are right to postpone,
I think).
I ran a complete doctest of the sage library, and tested building the
documentation, as well as playing with a few examples. Here are some
notes
* add empty file __init__.py (as mentioned above; this is required for
doctesting and to build documentation)
* add author to coordinate_patch.py
* I believe it is usual for gens() to return a tuple (rather than a
list); e.g.
{{{
sage: PolynomialRing(RR,3,'x,y,z').gens()
(x, y, z)
}}}
* `make ptestlong` passes all tests!
* Following the above suggestion, I added 'tensor' to `index.rst` and the
following to a new file `tensor.rst`. There are a few warnings when
building the documentation that need to be fixed, but mostly it looks
good.
{{{
Differential Forms
============
.. toctree::
:maxdepth: 2
sage/tensor/coordinate_patch
sage/tensor/differential_forms
sage/tensor/differential_form_element
}}}
* Is there a reason you call the directory `tensor` instead of e.g.
`diff_forms` or even `differential_forms`? I'm not an expert on
differential forms, so I defer to your judgment, but the latter seems more
intuitive to me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9650#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
