#9703: Doctest failures caused by non-working sympow on 32-bit Solaris x86 and
32-bit OpenSolaris
--------------------------------------------+-------------------------------
Reporter: drkirkby | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.5.3
Component: build | Keywords:
Author: David Kirkby | Upstream: Reported upstream.
Little or no feedback.
Reviewer: Jeroen Demeyer, Mitesh Patel | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by drkirkby):
Replying to [comment:24 mpatel]:
> I'm testing
>
>
http://boxen.math.washington.edu/home/kirkby/patches/sympow-1.018.1.p8.spkg
>
> on bsd, redhawk, sage, and t2.math.
>
> The patch looks good to me, except that I'm not qualified to review the
new `fpu.c`. But apart from that, I think we have a positive review.
>
> Jeroen, can you comment on `fpu.c`? Alternatively, David, could you
find someone to review this file?
I've asked on sage-devel if someone can comment on it. I suspect Jeroen
can. Here's the
[http://boxen.math.washington.edu/home/kirkby/patches/sympow-1.018.1.p8/src/fpu.c
original fpu.c]
and here's the changed version
[http://boxen.math.washington.edu/home/kirkby/patches/sympow-1.018.1.p8/patches/fpu.c
patched fpu.c]
One obvious difference is the original code just writes a number to the
control word, but I first read the control word, set two bits, then write
the control word.
The reason I did that was that one of the bits in that control word is
reserved by Intel, so I did not think it wise to write a number to the
register directly.
Having carefully read the documentation that comes with the later version
of quad-double, the only changes that should be made to that code is the
precision control bits, which is all I change.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9703#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
