#3893: random_element methods should all accept *args and **kwds
--------------------------------+-------------------------------------------
   Reporter:  malb              |       Owner:  somebody    
       Type:  enhancement       |      Status:  needs_review
   Priority:  major             |   Milestone:  sage-4.5.3  
  Component:  basic arithmetic  |    Keywords:              
     Author:  Niles Johnson     |    Upstream:  N/A         
   Reviewer:  Martin Albrecht   |      Merged:              
Work_issues:                    |  
--------------------------------+-------------------------------------------
Changes (by malb):

  * reviewer:  => Martin Albrecht


Comment:

 Replying to [comment:3 niles]:

 > Thanks for taking a look! Somewhere I gained the impression that
 doctests for a ticket should mention the ticket number--is that not
 necessarily the case?  I don't really have a strong opinion, but since it
 may be non-obvious functionality I'm in favor of keeping these tests in
 the EXAMPLES:: section.  How about rewording the description to something
 like the following? `Passes extra positional or keyword arguments through
 (Trac #3893)::`

 I'm not sure what the official policy is, but I'd say it would be a bit
 odd when in a few years time the docstring is cluttered with trac ticket
 numbers, what information do they communicate that is relevant? I am very
 much in favour of having "`Passes extra positional or keyword arguments
 through::`". I leave it up to you, so you have a positive review, i.e.
 toggle it yourself if you don't want to change it.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3893#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to