#8664: Upgrade Sage's MPIR spkg to version 2.1.1
---------------------------+------------------------------------------------
Reporter: was | Owner: GeorgSWeber
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.3
Component: packages | Keywords:
Author: Mike Hansen | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Comment(by leif):
Hmmm, {{{spkg-install}}} could be cleaned up further, e.g.
* Dave's comment has somehow been truncated(?) a while ago (''"... if"''
what?)
* {{{s/`uname`/$UNAME/}}}
* Especially for parallel builds, it's more convenient to begin ''every''
error message with {{{"Error"}}} (or at least the message should contain
that word).
* Simplify the "fat binary" section for Linux; it doesn't make sense to
call {{{uname -m}}} three times, nor does it to compare its result again
if it already matched one of the tested. A {{{case}}}-{{{esac}}} would be
appropriate, also merging the identical {{{i386}}} and {{{i686}}} then-
branches. Btw, {{{uname -m}}} can also be {{{i486}}} or {{{i586}}} on
32-bit Linuces.
* Is the {{{! [ $? -eq 0 ]}}} some required Cygwin "idiom"?
Also, {{{spkg-check}}} doesn't print any messages, and uses {{{make}}}
instead of {{{$MAKE}}}.
The dependencies ("None") in {{{SPKG.txt}}} are wrong; MPIR at least
depends on iconv, which Sage ships, though Sage's version is only
used/built on some systems. I'm not sure if readline should be added to
{{{spkg/standard/deps}}}. (MPIR's {{{configure}}} looks for much more, but
apparently - as currently shipped - doesn't need/use all of that.) The
Changelog could perhaps mention further changes, too.
If nobody else wants to, I could make the changes, i.e. a reviewer patch.
Just let me know...
Going to test the new spkg with Sage 4.5.3.alpha2 and 4.6.prealpha3 (on
Linuces only).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8664#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
