#8495: Regression: Many mathematica doctests now fail
------------------------------------------+---------------------------------
Reporter: flawrence | Owner: flawrence
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: interfaces | Keywords:
Author: Felix Lawrence | Upstream: N/A
Reviewer: Mike Hansen, Burcin Erocal | Merged:
Work_issues: |
------------------------------------------+---------------------------------
Changes (by burcin):
* status: needs_review => needs_work
* reviewer: Mike Hansen => Mike Hansen, Burcin Erocal
Comment:
This looks great! Many thanks for your work Felix.
Here is my review:
* Can you change the line lengths to be less than 78 characters? Some of
us still edit code using the terminal.
* There should be an empty line after `::` in the documentation. You can
also put the `::` sign right after the text, you don't need to make it a
separate line.
* On line 648 of `interfaces/mathematica.py`, you can change the test `if
result.find('"') != -1:` to `if '"' in result:`
* The dictionary merge in the `_sage_()` method might be expensive. I
think it's better to do it only if the locals dictionary is not empty.
Perhaps `lsymbols = symbol_table['mathematica'].copy();
lsymbols.update(locals)` would be faster.
* Using `sage_eval()` has lot's of security implications. Can we replace
it with `sage.calculus.calculus.SR_parser` or
`sage.calculus.calculus.symbolic_expression_from_string()` in this case?
This is definitely an improvement over what we have currently. I'd really
like to see it included in the next release.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8495#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
