#9337: Add toric divisors
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: doctest failures |
----------------------------------+-----------------------------------------
Changes (by novoselt):
* status: needs_review => needs_work
* work_issues: non-reduced divisor handling => doctest failures
Comment:
Thank you! ;-)
With the new patch:
{{{
sage -t devel/sage-main/sage/modular/abvar/abvar.py # 4 doctests
failed
sage -t devel/sage-main/sage/modular/modsym/ambient.py # 13
doctests failed
sage -t devel/sage-main/sage/modular/modform/element.py # 7
doctests failed
sage -t devel/sage-main/sage/modular/hecke/submodule.py # 1
doctests failed
sage -t devel/sage-main/sage/modular/hecke/module.py # 7 doctests
failed
sage -t devel/sage-main/sage/tests/book_stein_modform.py # 3
doctests failed
sage -t devel/sage-main/sage/algebras/group_algebra.py # 10
doctests failed
sage -t devel/sage-main/doc/en/bordeaux_2008/l_series.rst # 3
doctests failed
sage -t devel/sage-main/sage/modular/modsym/manin_symbols.py # 1
doctests failed
sage -t devel/sage-main/sage/modular/modsym/element.py # 5
doctests failed
sage -t devel/sage-main/sage/modular/modsym/modular_symbols.py #
55 doctests failed
sage -t devel/sage-main/doc/en/bordeaux_2008/modular_symbols.rst
# 1 doctests failed
}}}
I am a bit hesitant to prohibit using non-reduced formal sums and
divisors. It may make sense for toric divisors, but perhaps in other cases
people don't want to force reduce representation (otherwise, what's the
point of having a public `reduce` method?). So I think it would be better
to stick with fixes to toric modules. In any case existing doctests in the
above files should not fail because of modifications on this ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
