#9337: Add toric divisors
-------------------------------------------------------------------+--------
Reporter: vbraun |
Owner: AlexGhitza
Type: enhancement |
Status: needs_work
Priority: major |
Milestone: sage-4.6
Component: algebraic geometry |
Keywords:
Author: Volker Braun |
Upstream: N/A
Reviewer: Andrey Novoseltsev |
Merged:
Work_issues: add detailed comments to cohomology related methods |
-------------------------------------------------------------------+--------
Changes (by novoselt):
* status: needs_info => needs_work
* work_issues: => add detailed comments to cohomology related methods
Comment:
3. When there is a cohomology method that returns groups, it will be too
late to rename the current version, since it will break backward
compatibility ;-)
8. Then I definitely think that we should have a method `class_group()`
returning the honest class group, while the rational one should be
obtained either as `rational_class_group()` or `class_group(QQ)`...
Anyway, the updated patch deals with everything discussed above except for
4 (which I would like you to do on top) and these two issues, which you
can change or leave as is, if I still have not convinced you.
From the technical point of view it seems that everything is working fine
with my new patch. I will run tests of the whole library, build pdf
documentation and report if there are any issues.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
