#9400: modify the NumberField constructor to pass in optional integer B such
that
all the internal pari routines will replace the discriminant by its gcd
with B, making some things massively faster.
---------------------------------------------+------------------------------
Reporter: was | Owner: jdemeyer
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.6
Component: number fields | Keywords: PARI number field
Author: William Stein, Jeroen Demeyer | Upstream: N/A
Reviewer: Jeroen Demeyer, John Cremona | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Changes (by cremona):
* status: needs_review => positive_review
Comment:
Replying to [comment:32 cremona]:
> Replying to [comment:30 mpatel]:
> > John, do Jeroen's most recent changes look good to you?
>
> The new combined patch does look good. It applies smoothly to
4.6.alpha0, and the docs (re)build with no warnings. I am currently doing
a full test just to make sure. Will report back shortly.
All (long) tests pass -- positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9400#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
