#9400: modify the NumberField constructor to pass in optional integer B such
that
all the internal pari routines will replace the discriminant by its gcd
with B, making some things massively faster.
---------------------------------------------+------------------------------
Reporter: was | Owner: jdemeyer
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: number fields | Keywords: PARI number field
Author: William Stein, Jeroen Demeyer | Upstream: N/A
Reviewer: Jeroen Demeyer, John Cremona | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Changes (by was):
* status: needs_review => needs_work
Comment:
Hi,
I tried to apply my patch to 4.5.2.rc0 and it works fine:
{{{
adding trac_9400.patch to series file
applying trac_9400.patch
now at: trac_9400.patch
}}}
I tried to apply your patch (9400_combined.patch) and there are a massive
number of rejects:
{{{
adding 9400_combined.patch to series file
applying 9400_combined.patch
patching file sage/libs/pari/gen.pyx
Hunk #1 succeeded at 6408 with fuzz 2 (offset -32 lines).
Hunk #4 FAILED at 6964
Hunk #5 FAILED at 6991
2 out of 7 hunks FAILED -- saving rejects to file
sage/libs/pari/gen.pyx.rej
patching file sage/rings/number_field/number_field.py
Hunk #13 FAILED at 2870
Hunk #16 FAILED at 3727
2 out of 25 hunks FAILED -- saving rejects to file
sage/rings/number_field/number_field.py.rej
patching file sage/rings/number_field/number_field_ideal_rel.py
Hunk #2 FAILED at 592
1 out of 2 hunks FAILED -- saving rejects to file
sage/rings/number_field/number_field_ideal_rel.py.rej
patching file sage/rings/polynomial/polynomial_quotient_ring.py
Hunk #1 FAILED at 688
Hunk #2 FAILED at 1068
2 out of 2 hunks FAILED -- saving rejects to file
sage/rings/polynomial/polynomial_quotient_ring.py.rej
patching file sage/rings/residue_field.pyx
Hunk #17 succeeded at 427 with fuzz 2 (offset 0 lines).
Hunk #18 succeeded at 444 with fuzz 2 (offset 0 lines).
Hunk #19 FAILED at 463
Hunk #26 succeeded at 572 with fuzz 1 (offset -1 lines).
Hunk #27 FAILED at 589
2 out of 48 hunks FAILED -- saving rejects to file
sage/rings/residue_field.pyx.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 9400_combined.patch
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9400#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
