#9652: Unnecesary and buggy code in arith.py
------------------------+---------------------------------------------------
Reporter: mderickx | Owner: mderickx
Type: defect | Status: needs_info
Priority: minor | Milestone:
Component: algebra | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by lftabera):
* status: needs_review => needs_info
Comment:
Everything looks fine. Applies and passes doctest in 4.5.3
I have modified the header of the patch in
smallfix1-arith_valuation.2.3.patch and I have added another patch with a
new doctest regarding a previous issue that arrived before
valuation(1r,1r) not terminating.
Since I have not touched the code, I fell I can give possitive review, but
before doing so, mderickx, give me the OK for the change in the header of
your patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9652#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
