#9652: Unnecesary and buggy code in arith.py
------------------------+---------------------------------------------------
Reporter: mderickx | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: minor | Milestone:
Component: algebra | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by lftabera):
* status: needs_review => needs_work
Comment:
I found the following doctest failures (4.5.2):
sage -t -long "devel/sage-
devel/sage/quadratic_forms/count_local_2.pyx"[[BR]]
sage -t -long "devel/sage-
devel/sage/quadratic_forms/quadratic_form__count_local_2.py"[[BR]]
sage -t -long "devel/sage-
devel/sage/quadratic_forms/quadratic_form__local_density_congruence.py"[[BR]]
sage -t -long "devel/sage-
devel/sage/quadratic_forms/quadratic_form__local_representation_conditions.py"[[BR]]
all related with
AttributeError: 'sage.rings.finite_rings.integer_mod.IntegerMod_int'
object has no attribute 'valuation'
Also, in the code, you import Integers in the case of 'int' or 'float'.
However, the local namespace of arith contains ZZ. I have checked and it
is fastr to use ZZ(m) instead of importing Integer and using Integer(m).
This is a corner case though.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9652#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
