#9940: Fix equality/inequality for AdditiveAbelianGroup
----------------------------------+-----------------------------------------
Reporter: mpatel | Owner: jhpalmieri
Type: defect | Status: new
Priority: major | Milestone:
Component: algebraic topology | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Old description:
> With the optional CHomP package in 4.5.3 on sage.math, I get some doctest
> failures:
> {{{
> #!python
> sage -t -long -only-optional=chomp
> "devel/sage/sage/homology/cell_complex.py"
> **********************************************************************
> File
> "/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/cell_complex.py",
> line 470:
> sage: S2.homology(dim=2, generators=True) # optional - CHomP
> Expected:
> (Z, [(0, 1, 2) - (0, 1, 3) + (0, 2, 3) - (1, 2, 3)])
> Got:
> (Z, [-(0, 1, 2) + (0, 1, 3) - (0, 2, 3) + (1, 2, 3)])
> }}}
> These vary from run to run:
> {{{
> #!python
> sage -t -long -only-optional=chomp "devel/sage/sage/homology/tests.py"
> **********************************************************************
> File
> "/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
> line 10:
> sage: test_random_chain_complex(trials=20) # optional - CHomP
> Expected nothing
> Got:
> Homology in dimension 4 according to CHomP: C11
> Homology in dimension 4 according to Sage: C11
> Chain complex: {4: [], 5: 27 x 29 dense matrix over Integer Ring}
> Random testing has revealed a problem in test_random_chain_complex
> Please report this bug! You may be the first
> person in the world to have seen this problem.
> Please include this random seed in your bug report:
> Random seed: 53567958912087940719696565588289296809
> ValueError()
> **********************************************************************
> File
> "/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
> line 11:
> sage: test_random_chain_complex(level=2, trials=20) # optional -
> CHomP
> Expected nothing
> Got:
> Homology in dimension 36 according to CHomP: 0
> Homology in dimension 36 according to Sage: 0
> Chain complex: {36: 58 x 37 sparse matrix over Integer Ring, 37: 0 x
> 58 dense matrix over Integer Ring}
> Random testing has revealed a problem in test_random_chain_complex
> Please report this bug! You may be the first
> person in the world to have seen this problem.
> Please include this random seed in your bug report:
> Random seed: 194608326129552863405536402610270411271
> ValueError()
> **********************************************************************
> File
> "/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
> line 12:
> sage: test_random_chain_complex(level=4, trials=20) # long time #
> optional - CHomP
> Expected nothing
> Got:
> Homology in dimension 125 according to CHomP: Z^56
> Homology in dimension 125 according to Sage: Z^56
> Chain complex: {125: 0 x 173 dense matrix over Integer Ring, 126: 173
> x 117 dense matrix over Integer Ring}
> Random testing has revealed a problem in test_random_chain_complex
> Please report this bug! You may be the first
> person in the world to have seen this problem.
> Please include this random seed in your bug report:
> Random seed: 35064267617427002531027772896998931605
> ValueError()
> **********************************************************************
> File
> "/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
> line 72:
> sage: test_random_chain_complex(trials=2) # optional - CHomP
> Expected nothing
> Got:
> Homology in dimension -43 according to CHomP: 0
> Homology in dimension -43 according to Sage: 0
> Chain complex: {-43: 41 x 0 dense matrix over Integer Ring, -42: []}
> Random testing has revealed a problem in test_random_chain_complex
> Please report this bug! You may be the first
> person in the world to have seen this problem.
> Please include this random seed in your bug report:
> Random seed: 198276055669197070047963781696502632135
> ValueError()
> }}}
New description:
Inequality for the class {{{AdditiveAbelianGroup}}} has a bug:
{{{
sage: AdditiveAbelianGroup([0,0]) == AdditiveAbelianGroup([0,0])
True
sage: AdditiveAbelianGroup([0,0]) != AdditiveAbelianGroup([0,0])
True
}}}
This causes doctest failures as reported by mpatel: with the optional
CHomP package in 4.5.3 on sage.math, I get some doctest failures:
{{{
#!python
sage -t -long -only-optional=chomp
"devel/sage/sage/homology/cell_complex.py"
**********************************************************************
File
"/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/cell_complex.py",
line 470:
sage: S2.homology(dim=2, generators=True) # optional - CHomP
Expected:
(Z, [(0, 1, 2) - (0, 1, 3) + (0, 2, 3) - (1, 2, 3)])
Got:
(Z, [-(0, 1, 2) + (0, 1, 3) - (0, 2, 3) + (1, 2, 3)])
}}}
These vary from run to run:
{{{
#!python
sage -t -long -only-optional=chomp "devel/sage/sage/homology/tests.py"
**********************************************************************
File
"/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
line 10:
sage: test_random_chain_complex(trials=20) # optional - CHomP
Expected nothing
Got:
Homology in dimension 4 according to CHomP: C11
Homology in dimension 4 according to Sage: C11
Chain complex: {4: [], 5: 27 x 29 dense matrix over Integer Ring}
Random testing has revealed a problem in test_random_chain_complex
Please report this bug! You may be the first
person in the world to have seen this problem.
Please include this random seed in your bug report:
Random seed: 53567958912087940719696565588289296809
ValueError()
**********************************************************************
File
"/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
line 11:
sage: test_random_chain_complex(level=2, trials=20) # optional -
CHomP
Expected nothing
Got:
Homology in dimension 36 according to CHomP: 0
Homology in dimension 36 according to Sage: 0
Chain complex: {36: 58 x 37 sparse matrix over Integer Ring, 37: 0 x
58 dense matrix over Integer Ring}
Random testing has revealed a problem in test_random_chain_complex
Please report this bug! You may be the first
person in the world to have seen this problem.
Please include this random seed in your bug report:
Random seed: 194608326129552863405536402610270411271
ValueError()
**********************************************************************
File
"/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
line 12:
sage: test_random_chain_complex(level=4, trials=20) # long time #
optional - CHomP
Expected nothing
Got:
Homology in dimension 125 according to CHomP: Z^56
Homology in dimension 125 according to Sage: Z^56
Chain complex: {125: 0 x 173 dense matrix over Integer Ring, 126: 173
x 117 dense matrix over Integer Ring}
Random testing has revealed a problem in test_random_chain_complex
Please report this bug! You may be the first
person in the world to have seen this problem.
Please include this random seed in your bug report:
Random seed: 35064267617427002531027772896998931605
ValueError()
**********************************************************************
File
"/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/tests.py",
line 72:
sage: test_random_chain_complex(trials=2) # optional - CHomP
Expected nothing
Got:
Homology in dimension -43 according to CHomP: 0
Homology in dimension -43 according to Sage: 0
Chain complex: {-43: 41 x 0 dense matrix over Integer Ring, -42: []}
Random testing has revealed a problem in test_random_chain_complex
Please report this bug! You may be the first
person in the world to have seen this problem.
Please include this random seed in your bug report:
Random seed: 198276055669197070047963781696502632135
ValueError()
}}}
--
Comment(by jhpalmieri):
I think we could fix the doctest failures by changing {{{A != B}}} to
{{{not A == B}}}, because very brief testing suggests that {{{==}}} works
for these objects, but that wouldn't fix the underlying issue.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9940#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
