#9952: make SAGE_CHECK work with SAGE_ATLAS_LIB
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.6
Component: packages | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by leif):
I'd say there's a slight difference between {{{test -z ...}}} and {{{[ -z
... ]}}}, but I can't confirm that for the example given because my
{{{ksh}}} isn't broken like the mentioned Solaris one.
I won't consider this a real ''portability'' issue (at least in our case),
but a matter of ''robustness''. Furthermore, at that point we can rely on
{{{SAGE_ATLAS_LIB}}} being unset or empty, or containing a valid filename
IIRC.
W.r.t {{{$}}}, of course {{{$SAGE_ATLAS_LIB}}} refers to ''the value'' of
the environment variable {{{SAGE_ATLAS_LIB}}}, but the former might be
clearer to some users in case one omits ''"The environment variable
..."''.
I think Dave's
{{{
#!sh
echo "SAGE_ATLAS_LIB is set to $SAGE_ATLAS_LIB; skipping test suite."
}}}
is also more explicit, though I'd add (escaped) double quotes around the
variable's value.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9952#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
