#9952: make SAGE_CHECK work with SAGE_ATLAS_LIB
-----------------------------+----------------------------------------------
   Reporter:  jhpalmieri     |       Owner:  tbd         
       Type:  defect         |      Status:  needs_review
   Priority:  minor          |   Milestone:  sage-4.6    
  Component:  packages       |    Keywords:              
     Author:  John Palmieri  |    Upstream:  N/A         
   Reviewer:                 |      Merged:              
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by drkirkby):

 I agree with Leif, the $ in the message should be skipped. We have
 refereed to SAGE_ATLAS_LIB before, so I think it's best to refer to it as
 that and not $SAGE_ATLAS_LIB. But it works fine.

 {{{
 real    0m0.147s
 user    0m0.060s
 sys     0m0.085s
 Successfully installed atlas-3.8.3.p16
 Running the test suite.
 $SAGE_ATLAS_LIB is set; skipping test suite.
 Now cleaning up tmp files.
 Making Sage/Python scripts relocatable...
 Making script relocatable
 Finished installing atlas-3.8.3.p16.spkg
 drkir...@hawk:~/sage-4.6.alpha1$
 }}}

 Arguably a nice touch would be to add

 {{{
 echo "SAGE_ATLAS_LIB is set to $SAGE_ATLAS_LIB; skipping test suite."
 }}}

 BTW, one more stupid thing, which is nothing to do with you, but a result
 of a bad bit of code being copied around everywhere, is there's no need
 for the semi-colon on the line

 {{{
 echo "SAGE_LOCAL undefined ... exiting";
 }}}

 You might as well remove that at the same time.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9952#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to