#8334: Improvements to residue fields
---------------------------+------------------------------------------------
Reporter: roed | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: algebra | Keywords:
Author: David Roe | Upstream: N/A
Reviewer: | Merged:
Work_issues: conflicts |
---------------------------+------------------------------------------------
Changes (by davidloeffler):
* status: needs_review => needs_work
* work_issues: => conflicts
Comment:
It doesn't work. On vanilla 4.6.alpha1, if I apply
{{{
7883_ideals.patch
7883_fixes.patch
8333_parent_init.patch
8333_finite_fields_to_new_coercion.2.patch
7585_9_1_frac_and_coerce_updates.patch
8334_residue_fields-rebased_for_8446.patch
}}}
then the first five apply (with minor fuzz) but the last one is completely
knackered, with 23 out of 27 hunks failing. I think the problem is caused
by #9343/#9400 which both make extensive changes to residue fields.
Just a general observation: you've managed to virtually guarantee that
these patches are impossible to review, because they're all linked
together in such a way that they fail doctests unless you apply the whole
series. So the effect is a huge patch bomb, which is unappealing to
review; hence it sits around for ages, and inevitably bitrots. Please,
please, please back-port the doctest fixes etc, so each ticket in the
series passes doctests on its own. Otherwise this will really never get
merged and all of your hard work writing this excellent code (not to
mention the work of those who have attempted to review it) will be for
nothing.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8334#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
