#9049: v4.4.1 bug in variety() over finite field extensions of Q?
----------------------------------+-----------------------------------------
   Reporter:  cynthia_vinzant     |       Owner:  AlexGhitza  
       Type:  defect              |      Status:  needs_review
   Priority:  major               |   Milestone:  sage-4.6.1  
  Component:  linear algebra      |    Keywords:              
     Author:  Andrey Novoseltsev  |    Upstream:  N/A         
   Reviewer:  Burcin Erocal       |      Merged:              
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by burcin):

 Thanks! That was quick. :)

 I suggest to replace the check
 {{{
 if not isinstance(entries, list):
 }}}
 with
 {{{
 if not isinstance(entries, (list, tuple)):
 }}}
 instead of accepting `ValueError`s as well.

 attachment:trac_9049_bug_in_matrices_from_tuples.take2.patch includes this
 alternative approach.

 Please switch this to `positive_review` if you agree with my changes.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9049#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to