#8939: matrix classes for flint polynomials
-------------------------------+--------------------------------------------
Reporter: burcin | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: linear algebra | Keywords:
Author: Burcin Erocal | Upstream: N/A
Reviewer: Martin Albrecht | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by burcin):
* status: needs_work => needs_review
* reviewer: => Martin Albrecht
Comment:
Replying to [comment:4 malb]:
> The patch looks good. However, I'd prefer to have a bit more
documentation.
> * I think there should be doctests in {{{fmpz_poly_linkage.pxi}}}. I
know our policy does not require it, but it seems like a good pplace to
put some
Done. I added a new file `sage/libs/flint/fmpz_poly_linkage_tests.pyx`
with python functions wrapping the `celement_*()` functions. I don't know
how to test the `celement_{construct,destruct}()` functions, so they are
omitted.
> * It would be nice to write a bit about how all the files (templates
etc.) relate to each other, e.g. some documentation in
{{{matrix_dense_template.pxi}}} which makes it explains a bit how to use
it. (I guess I should do the same for the polynomial template thing.)
Done, with a brief description at the beginning of
`matrix_dense_template.pxi`.
> * I cannot see the "fast nullspace"
This will be on a different ticket, when I get around to cleaning it up...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8939#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
