#9972: Add toric lattice morphisms
-------------------------------------+--------------------------------------
   Reporter:  novoselt               |       Owner:  mhampton  
       Type:  enhancement            |      Status:  needs_work
   Priority:  major                  |   Milestone:  sage-4.6  
  Component:  geometry               |    Keywords:            
     Author:  Andrey Novoseltsev     |    Upstream:  N/A       
   Reviewer:  Volker Braun           |      Merged:            
Work_issues:  switch to FanMorphism  |  
-------------------------------------+--------------------------------------

Comment(by vbraun):

 Adding the functionality to `__call__` still does not enforce that
 `ambient_ray_indices` is used correctly. In particular, it would not have
 caught the bug in `ToricDivisor`.

 How about we remove the `ambient_ray_indices()` method from cones
 altogether and replace it with `fan.ray_indices(cone)`.

 I agree with 3.

 I don't think that the `Cone_of_fan` uniqueness is particularly urgent, we
 can come back to that later.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to