#9972: Add toric lattice morphisms
-------------------------------------+--------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: switch to FanMorphism |
-------------------------------------+--------------------------------------
Comment(by vbraun):
One potential danger is that `cone.ambient_ray_indices()` is meaningless
if `cone` is only mathematically equivalent to a fan, but not a
`Cone_of_fan`. I've added a new method
`RationalPolyhedralFan.get_cone(cone)` that finds the `Cone_of_fan`
corresponding to the cone, and I tried to make sure it gets called
wherever we accept arbitrary cones from the user.
But its a potential pitfall to watch out for. We could always insist on
the user passing only `Cone_of_fan`, but that seems to be too unwieldy for
the user. I would suggest that we move the `ambient_ray_indices()`
accessor method to `Cone_of_fan` and convert the code in `cone.py`,
`fan.py` to use the data member `_ambient_ray_indices` instead. All higher
level functions then shall only use `cone.ambient_ray_indices()`,
converting a generic cone to a `Cone_of_fan` via `fan.get_cone(cone)` if
necessary.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
