#10115: Change _sig_on to sig_on()
---------------------------+------------------------------------------------
Reporter: jdemeyer | Owner: tba
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.6
Component: c_lib | Keywords: _sig_on _sig_off
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Changes (by jdemeyer):
* milestone: sage-4.6.1 => sage-4.6
Old description:
> Right now, {{{_sig_on}}} is a macro. However, in the light of future
> changes at #9678, it would be better to make it have function syntax and
> write {{{_sig_on()}}} instead. The same for {{{_sig_off}}}.
>
> So in this ticket, I would simpy change the syntax from {{{_sig_on}}} to
> {{{_sig_on()}}} without changing what it does.
>
> This will prepare the way for #9678 when {{{_sig_on()}}} will actually
> become an inline function (there are several reasons why this would be
> better).
New description:
Right now, {{{_sig_on}}} is a macro. However, in the light of future
changes at #9678, it would be better to make it have function syntax and
write {{{_sig_on()}}} instead. The same for {{{_sig_off}}}. While we're
at it, why not drop the leading underscore and make it {{{sig_on()}}}?
The {{{sig_on}}} macro/function isn't really "private", it's used all over
the place and it should be used by users writing their own Cython code.
So in this ticket, I would simpy change the syntax from {{{_sig_on}}} to
{{{sig_on()}}} without changing what it does.
This will prepare the way for #9678 when {{{sig_on()}}} will actually
become an inline function (there are several reasons why this would be
better).
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10115#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
